More buffer tagging cleanup by rbrchen · Pull Request #984 · openjdk/babylon

rbrchen · 2026-03-26T23:05:02Z

Delete and refactor unnecessary buffer tagging code.

Also remove the @reflect annotation on S32Array::arrayView - this makes the buffer tagging break.

Progress

Change must not contain extraneous whitespace

Error

⚠️ Pull request body is missing required line: - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/984/head:pull/984
$ git checkout pull/984

Update a local copy of the PR:
$ git checkout pull/984
$ git pull https://git.openjdk.org/babylon.git pull/984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 984

View PR using the GUI difftool:
$ git pr show -t 984

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/984.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-03-26T23:06:11Z

👋 Welcome back rbrchen! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-26T23:06:59Z

@rbrchen This change is no longer ready for integration - check the PR body for details.

mlbridge · 2026-03-26T23:10:34Z

Webrevs

grfrost · 2026-03-31T09:20:57Z

-                if (invokeOp != null) return invokeOp.result();
+                if (invokeOp != null) {
+                    return invokeOp.result();
+                }


If this is null what do we return? Maybe we dont expect this ever to be the case. In which case shoudl we throw?

grfrost · 2026-03-31T09:26:20Z

@@ -123,10 +127,14 @@ private static Value getRootValue(Op op) {
            }
            case JavaOp.InvokeOp invokeOp -> {


All of this would be easier I think if you used the Invoke wrapper.

bridgekeeper · 2026-04-29T04:57:33Z

@rbrchen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

grfrost · 2026-04-29T11:25:11Z

/touch

openjdk · 2026-04-29T11:25:30Z

@grfrost The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk · 2026-04-29T11:26:20Z

@rbrchen this pull request can not be integrated into code-reflection due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout cleanup
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push

rbrchen added 2 commits March 26, 2026 15:54

Initial buffer tagger refactoring

01404f3

More cleanup

0f0c339

openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2026

grfrost reviewed Mar 27, 2026

View reviewed changes